hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6668) Use cgroup to get container resource utilization
Date Tue, 20 Jun 2017 23:22:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056656#comment-16056656
] 

ASF GitHub Bot commented on YARN-6668:
--------------------------------------

Github user haibchen commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/241#discussion_r123104774
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
---
    @@ -588,6 +589,31 @@ private void initializeProcessTrees(
         }
     
         /**
    +     * Get the best process tree calculator.
    +     * @param pId container process id
    +     * @return process tree calculator
    +     */
    +    private ResourceCalculatorProcessTree
    +        getResourceCalculatorProcessTree(String pId) {
    +      ResourceCalculatorProcessTree pt = null;
    +
    +      // CGroups is best in perforance, so try to use it, if it is enabled
    +      if (processTreeClass == null &&
    --- End diff --
    
    Maybe we could move this into ResourceCalculatorProcessTree.getResourceCalculatorProcessTree()?


> Use cgroup to get container resource utilization
> ------------------------------------------------
>
>                 Key: YARN-6668
>                 URL: https://issues.apache.org/jira/browse/YARN-6668
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Haibo Chen
>            Assignee: Miklos Szegedi
>
> Container Monitor relies on proc file system to get container resource utilization, which
is not as efficient as reading cgroup accounting. We should in NM, when cgroup is enabled,
read cgroup stats instead. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message