hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5647) [Security] Collector side changes for loading auth filters and principals
Date Mon, 05 Jun 2017 14:24:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-5647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037029#comment-16037029

Varun Saxena commented on YARN-5647:

Thanks [~jianhe] and [~rohithsharma] for the review.

bq. Btw, why do we want to modify TimelineDelegationTokenIdentifier? Who will be calling renew/cancel
for timeline token?
bq. Is this not supported temporarily or not going to be supported. I think throwing exception
is a bit harsh. If user accidentally set it to be 2.0 in RM, RM will fail in this case. May
not throw exception here ?
Intention was not to support it temporarily. Because eventually we can have a facility for
frameworks to get delegation tokens.
However as this required discussion and TimelineClientImpl was had get DT API, I had introduced
this check. 
Anyways after YARN-4129 has gone in recently, we have separated client interface for ATSv1
and ATSv2 and ATSv2 interface has no way to get/renew/cancel DT, so we can remove this code.

bq. May be you can use YarnConfiguration.timelineServiceV2Enabled(conf) 
OK. Will do so wherever possible.

bq. TimelineUtils#addTimelineFilters has some duplicated code as ApplicationHistoryServer
- creating a util method ?
Yeah we can probably reuse some of the stuff. Let me see how to do it.

bq. first start webapp and start parent threads?
Well the reason I did it was webapp is serving layer so dependent services which will be used
when requests come should be started first. Right now either ways would work as only token
removal thread is started as part of DT manager but in principle, I think webapp should start

> [Security] Collector side changes for loading auth filters and principals
> -------------------------------------------------------------------------
>                 Key: YARN-5647
>                 URL: https://issues.apache.org/jira/browse/YARN-5647
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-5647-YARN-5355.004.patch, YARN-5647-YARN-5355.005.patch, YARN-5647-YARN-5355.006.patch,
YARN-5647-YARN-5355.007.patch, YARN-5647-YARN-5355.wip.002.patch, YARN-5647-YARN-5355.wip.003.patch,

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message