hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-5647) [Security] Collector side changes for loading auth filters and principals
Date Fri, 02 Jun 2017 23:43:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-5647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035634#comment-16035634
] 

Jian He edited comment on YARN-5647 at 6/2/17 11:42 PM:
--------------------------------------------------------

Thanks Varun for working on the this ! few comments:
- TimelineUtils#addTimelineFilters has some duplicated code as ApplicationHistoryServer -
creating a util method ?
-  Is this not supported temporarily or not going to be supported. I think throwing exception
is a bit harsh. If user accidentally set it to be 2.0 in RM, RM will fail in this case. May
not throw exception here ?
{code}
      if (conf.getFloat(YarnConfiguration.TIMELINE_SERVICE_VERSION,
          YarnConfiguration.DEFAULT_TIMELINE_SERVICE_VERSION) == 2.0f) {
        throw new UnsupportedOperationException("Token renewal is not " +
            "supported for timeline service v.2");
      }
      {code}


was (Author: jianhe):
Thanks 
- TimelineUtils#addTimelineFilters has some duplicated code as ApplicationHistoryServer -
creating a util method ?
-  Is this not supported temporarily or not going to be supported. I think throwing exception
is a bit harsh. If user accidentally set it to be 2.0 in RM, RM will fail in this case. May
not throw exception here ?
{code}
      if (conf.getFloat(YarnConfiguration.TIMELINE_SERVICE_VERSION,
          YarnConfiguration.DEFAULT_TIMELINE_SERVICE_VERSION) == 2.0f) {
        throw new UnsupportedOperationException("Token renewal is not " +
            "supported for timeline service v.2");
      }
      {code}

> [Security] Collector side changes for loading auth filters and principals
> -------------------------------------------------------------------------
>
>                 Key: YARN-5647
>                 URL: https://issues.apache.org/jira/browse/YARN-5647
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-5647-YARN-5355.004.patch, YARN-5647-YARN-5355.005.patch, YARN-5647-YARN-5355.006.patch,
YARN-5647-YARN-5355.007.patch, YARN-5647-YARN-5355.wip.002.patch, YARN-5647-YARN-5355.wip.003.patch,
YARN-5647-YARN-5355.wip.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message