Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ED114200C7F for ; Wed, 24 May 2017 19:43:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EBBFD160BD0; Wed, 24 May 2017 17:43:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3CAF6160BA5 for ; Wed, 24 May 2017 19:43:08 +0200 (CEST) Received: (qmail 79097 invoked by uid 500); 24 May 2017 17:43:07 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 79076 invoked by uid 99); 24 May 2017 17:43:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 May 2017 17:43:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 05152CA983 for ; Wed, 24 May 2017 17:43:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Bi-AbpoI2ESa for ; Wed, 24 May 2017 17:43:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0451B5FD90 for ; Wed, 24 May 2017 17:43:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 302F6E0D95 for ; Wed, 24 May 2017 17:43:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3710521B5E for ; Wed, 24 May 2017 17:43:04 +0000 (UTC) Date: Wed, 24 May 2017 17:43:04 +0000 (UTC) From: "Botong Huang (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YARN-6640) AM heartbeat stuck when responseId overflows MAX_INT MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 24 May 2017 17:43:09 -0000 [ https://issues.apache.org/jira/browse/YARN-6640?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated YARN-6640: ------------------------------- Description:=20 The current code in {{ApplicationMasterService}}:=20 if ((request.getResponseId() + 1) =3D=3D lastResponse.getResponseId()) {/* = old heartbeat */ return lastResponse;}=20 else if (request.getResponseId() + 1 < lastResponse.getResponseId()) { thro= w ... } process the heartbeat... When a heartbeat comes in, in usual case we are expecting request.getRespon= seId() =3D=3D lastResponse.getResponseId(). The =E2=80=9Cif=E2=80=9C is for= the duplicate heartbeat that=E2=80=99s one step old, the =E2=80=9Celse if= =E2=80=9D is to throw and complain for heartbeats more than two steps old, = otherwise we accept the new heartbeat and process it. So the bug is: when lastResponse.getResponseId() =3D=3D MAX_INT, the newest= heartbeat comes in with responseId =3D=3D MAX_INT. However reponseId + 1 w= ill be MIN_INT, and we will fall into the =E2=80=9Celse if=E2=80=9D case an= d RM will throw. Then we are stuck here=E2=80=A6 was: The current code in {{ApplicationMasterService}}:=20 if ((request.getResponseId() + 1) =3D=3D lastResponse.getResponseId()) { /* old heartbeat */ return lastResponse; } else if (request.getResponseId() + 1 < lastResponse.getResponseId()) { throw ... } process the heartbeat... When a heartbeat comes in, in usual case we are expecting request.getRespon= seId() =3D=3D lastResponse.getResponseId().=20 The =E2=80=9Cif=E2=80=9C is for the duplicate heartbeat that=E2=80=99s one = step old, the =E2=80=9Celse if=E2=80=9D is to throw and complain for heartb= eats more than two steps old, otherwise we accept the new heartbeat and pro= cess it. So the bug is: when lastResponse.getResponseId() =3D=3D MAX_INT, the newest= heartbeat comes in with responseId =3D=3D MAX_INT.=20 However reponseId + 1 will be MIN_INT, and we will fall into the =E2=80=9Ce= lse if=E2=80=9D case and RM will throw. Then we are stuck here=E2=80=A6 > AM heartbeat stuck when responseId overflows MAX_INT > ----------------------------------------------------- > > Key: YARN-6640 > URL: https://issues.apache.org/jira/browse/YARN-6640 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Botong Huang > Assignee: Botong Huang > Priority: Minor > > The current code in {{ApplicationMasterService}}:=20 > if ((request.getResponseId() + 1) =3D=3D lastResponse.getResponseId()) {/= * old heartbeat */ return lastResponse;}=20 > else if (request.getResponseId() + 1 < lastResponse.getResponseId()) { th= row ... } > process the heartbeat... > When a heartbeat comes in, in usual case we are expecting request.getResp= onseId() =3D=3D lastResponse.getResponseId(). The =E2=80=9Cif=E2=80=9C is f= or the duplicate heartbeat that=E2=80=99s one step old, the =E2=80=9Celse i= f=E2=80=9D is to throw and complain for heartbeats more than two steps old,= otherwise we accept the new heartbeat and process it. > So the bug is: when lastResponse.getResponseId() =3D=3D MAX_INT, the newe= st heartbeat comes in with responseId =3D=3D MAX_INT. However reponseId + 1= will be MIN_INT, and we will fall into the =E2=80=9Celse if=E2=80=9D case = and RM will throw. Then we are stuck here=E2=80=A6 -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org