Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BFCC5200C72 for ; Fri, 12 May 2017 20:00:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BE4F6160BB8; Fri, 12 May 2017 18:00:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 10B22160BA8 for ; Fri, 12 May 2017 20:00:13 +0200 (CEST) Received: (qmail 47403 invoked by uid 500); 12 May 2017 18:00:13 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 47390 invoked by uid 99); 12 May 2017 18:00:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 May 2017 18:00:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AF975181946 for ; Fri, 12 May 2017 18:00:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id QtRzr-DE91vD for ; Fri, 12 May 2017 18:00:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 87EF55FE51 for ; Fri, 12 May 2017 18:00:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EA189E0D90 for ; Fri, 12 May 2017 18:00:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1A38E24343 for ; Fri, 12 May 2017 18:00:06 +0000 (UTC) Date: Fri, 12 May 2017 18:00:06 +0000 (UTC) From: "Daniel Templeton (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Issue Comment Deleted] (YARN-4209) RMStateStore FENCED state doesn't work due to updateFencedState called by stateMachine.doTransition MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 12 May 2017 18:00:14 -0000 [ https://issues.apache.org/jira/browse/YARN-4209?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated YARN-4209: ----------------------------------- Comment: was deleted (was: Replaced gendered quote it summary) > RMStateStore FENCED state doesn't work due to updateFencedState called by= stateMachine.doTransition > -------------------------------------------------------------------------= -------------------------- > > Key: YARN-4209 > URL: https://issues.apache.org/jira/browse/YARN-4209 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Affects Versions: 2.7.2 > Reporter: zhihai xu > Assignee: zhihai xu > Priority: Critical > Fix For: 2.8.0, 2.7.2, 3.0.0-alpha1 > > Attachments: YARN-4209.000.patch, YARN-4209.001.patch, YARN-4209.= 002.patch, YARN-4209.branch-2.7.patch > > > RMStateStore FENCED state doesn=E2=80=99t work due to {{updateFencedState= }} called by {{stateMachine.doTransition}}. The reason is > {{stateMachine.doTransition}} called from {{updateFencedState}} is embedd= ed in {{stateMachine.doTransition}} called from public API(removeRMDelegati= onToken...) or {{ForwardingEventHandler#handle}}. So right after the intern= al state transition from {{updateFencedState}} changes the state to FENCED = state, the external state transition changes the state back to ACTIVE state= . The end result is that RMStateStore is still in ACTIVE state even after {= {notifyStoreOperationFailed}} is called. The only working case for FENCED s= tate is {{notifyStoreOperationFailed}} called from {{ZKRMStateStore#VerifyA= ctiveStatusThread}}. > For example: {{removeRMDelegationToken}} =3D> {{handleStoreEvent}} =3D> e= nter external {{stateMachine.doTransition}} =3D> {{RemoveRMDTTransition}} = =3D> {{notifyStoreOperationFailed}} =3D>{{updateFencedState}}=3D>{{handleSt= oreEvent}}=3D> enter internal {{stateMachine.doTransition}} =3D> exit inter= nal {{stateMachine.doTransition}} change state to FENCED =3D> exit external= {{stateMachine.doTransition}} change state to ACTIVE. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org