Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 15 May 2017 21:43:04 +0000 (UTC)
From: "Eric Payne (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12717218.1401343413000.215477.1494884584562@Atlassian.JIRA>
In-Reply-To: <JIRA.12717218.1401343413000@Atlassian.JIRA>
References: <JIRA.12717218.1401343413000@Atlassian.JIRA> <JIRA.12717218.1401343413113@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-2113) Add cross-user preemption within
 CapacityScheduler's leaf-queue
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 15 May 2017 21:43:10 -0000


    [ https://issues.apache.org/jira/browse/YARN-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011384#comment-16011384 ] 

Eric Payne commented on YARN-2113:
----------------------------------

[~sunilg], the unit test was not failing for a couple of reasons. First, it was still using the {{DefaultResourceCalculator}} even though the {{TestProportionalCapacityPreemptionPolicyIntraQueueWithDRF#setup}} was setting {{rc}} to {{DominantResourceCalculator}}.

First, I think {{when(cs.getResourceCalculator()).thenReturn(rc);}} should be added
{code:title=TestProportionalCapacityPreemptionPolicyIntraQueueWithDRF#setup}
  public void setup() {
    super.setup();
    conf.setBoolean(
        CapacitySchedulerConfiguration.INTRAQUEUE_PREEMPTION_ENABLED, true);
    rc = new DominantResourceCalculator();
   when(cs.getResourceCalculator()).thenReturn(rc);
    policy = new ProportionalCapacityPreemptionPolicy(rmContext, cs, mClock);
  }
{code}

Second, in each of the tests, {{String labelsConfig = "=100:50,true;";}} should be changed to {{String labelsConfig = "=100:200,true;";}}

By making these changes, the tests will fail. If I comment out the {{when...thenReturn}}, the test succeeds again because it goes back to using the {{DefaultResourceCalculator}}

> Add cross-user preemption within CapacityScheduler's leaf-queue
> ---------------------------------------------------------------
>
>                 Key: YARN-2113
>                 URL: https://issues.apache.org/jira/browse/YARN-2113
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Sunil G
>         Attachments: IntraQueue Preemption-Impact Analysis.pdf, TestNoIntraQueuePreemptionIfBelowUserLimitAndDifferentPrioritiesWithExtraUsers.txt, YARN-2113.0001.patch, YARN-2113.0002.patch, YARN-2113.0003.patch, YARN-2113.0004.patch, YARN-2113.0005.patch, YARN-2113.0006.patch, YARN-2113.0007.patch, YARN-2113.0008.patch, YARN-2113.0009.patch, YARN-2113.0010.patch, YARN-2113.0011.patch, YARN-2113.0012.patch, YARN-2113.0013.patch, YARN-2113.0014.patch, YARN-2113.0015.patch, YARN-2113.0016.patch, YARN-2113.0017.patch, YARN-2113.apply.onto.0012.ericp.patch, YARN-2113 Intra-QueuePreemption Behavior.pdf, YARN-2113.v0.patch
>
>
> Preemption today only works across queues and moves around resources across queues per demand and usage. We should also have user-level preemption within a queue, to balance capacity across users in a predictable manner.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org