hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yufei Gu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6582) FSAppAttempt demand can be updated atomically in updateDemand()
Date Thu, 25 May 2017 20:54:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-6582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025381#comment-16025381
] 

Yufei Gu commented on YARN-6582:
--------------------------------

Thanks [~kasha] for working on this. The patch looks good to me. Both {{getSchedulerKeys()}}
and {{getPendingAsk}} are fine after removing the write lock. +1.

> FSAppAttempt demand can be updated atomically in updateDemand()
> ---------------------------------------------------------------
>
>                 Key: YARN-6582
>                 URL: https://issues.apache.org/jira/browse/YARN-6582
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: YARN-6582.001.patch
>
>
> FSAppAttempt#updateDemand first sets demand to 0, and then adds up all the outstanding
requests. Instead, we could use another variable tmpDemand to build the new value and atomically
replace the demand.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message