hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Soumabrata Chakraborty (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6475) Fix some long function checkstyle issues
Date Wed, 10 May 2017 18:08:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005128#comment-16005128
] 

Soumabrata Chakraborty commented on YARN-6475:
----------------------------------------------

Hi [~templedf],  [~miklos.szegedi@cloudera.com]

With reference to the auto-generated comments from Hadoop QA above:
1. There are no new or modified tests since the patch does not change current behavior of
the code in any way -- it just refactors code and makes it more readable.  In fact, we rely
on the existing tests passing to ensure that the refactoring has not broken any functionality.
2. The extant findbugs warnings was not the focus of my patch.  I can give them a shot if
you feel they should be handled together with this JIRA.

Please advise

> Fix some long function checkstyle issues
> ----------------------------------------
>
>                 Key: YARN-6475
>                 URL: https://issues.apache.org/jira/browse/YARN-6475
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Miklos Szegedi
>            Assignee: Soumabrata Chakraborty
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 3.0.0-alpha3
>
>         Attachments: YARN-6475.001.patch
>
>
> I am talking about these two:
> {code}
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java:441:
 @Override:3: Method length is 176 lines (max allowed is 150). [MethodLength]
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java:159:
 @Override:3: Method length is 158 lines (max allowed is 150). [MethodLength]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message