hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-5411) Create a proxy chain for ApplicationClientProtocol in the Router
Date Wed, 03 May 2017 18:14:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995281#comment-15995281
] 

Subru Krishnan edited comment on YARN-5411 at 5/3/17 6:13 PM:
--------------------------------------------------------------

Thanks [~giovanni.fumarola] for addressing my comments. I have manually kicked Yetus as it
didn't pick up the latest patch. 

Regarding the version in pom.xml, you should add the test-jar in the hadoop main pom [here|https://github.com/apache/hadoop/blob/trunk/hadoop-project/pom.xml]
and then the version gets automatically inherited.

You seemed to have missed this suggestion:
bq. MockClientRequestInterceptor should extend DefaultClientRequestInterceptor and only override
init.

A clarification regarding {{MockResourceManagerFacade}} - why do we need it as there's {{MockRM}}
already which is widely used in tests. IF we do need it, call out in the class Javadocs that
it's used by {{AMRMProxy/Router}} tests.



was (Author: subru):
Thanks [~giovanni.fumarola] for addressing my comments. I have manually kicked Yetus as it
didn't pick up the latest patch. 

Regarding the version in pom.xml, you should add the test-jar in the hadoop main pom [here|https://github.com/apache/hadoop/blob/trunk/hadoop-project/pom.xml]
and then the version gets automatically inherited.

You seemed to have missed this suggestion:
bq. MockClientRequestInterceptor should extend DefaultClientRequestInterceptor and only override
init.


> Create a proxy chain for ApplicationClientProtocol in the Router
> ----------------------------------------------------------------
>
>                 Key: YARN-5411
>                 URL: https://issues.apache.org/jira/browse/YARN-5411
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Giovanni Matteo Fumarola
>         Attachments: YARN-5411-YARN-2915.v1.patch, YARN-5411-YARN-2915.v2.patch, YARN-5411-YARN-2915.v3.patch,
YARN-5411-YARN-2915.v4.patch
>
>
> As detailed in the proposal in the umbrella JIRA, we are introducing a new component
that routes client request to appropriate ResourceManager(s). This JIRA tracks the creation
of a proxy for ApplicationClientProtocol in the Router. This provides a placeholder for:
> 1) throttling mis-behaving clients (YARN-1546)
> 3) mask the access to multiple RMs (YARN-3659)
> We are planning to follow the interceptor pattern like we did in YARN-2884 to generalize
the approach and have only dynamically coupling for Federation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message