hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4925) ContainerRequest in AMRMClient, application should be able to specify nodes/racks together with nodeLabelExpression
Date Wed, 31 May 2017 20:21:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-4925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031876#comment-16031876
] 

Konstantin Shvachko commented on YARN-4925:
-------------------------------------------

I've done quite a few runs for the client tests.
I see {{TestAMRMClient}} and other client tests failing consistently on my Linux box. On Mac
they succeed most of the time, but also fail once in a while. I don't think it is related
to this particular patch, but I don't know for sure.
So I think we should get some understanding on why the tests are failing, which will give
us an idea if we can commit this jira and focus on fixing the tests for branch-2.7.

> ContainerRequest in AMRMClient, application should be able to specify nodes/racks together
with nodeLabelExpression
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4925
>                 URL: https://issues.apache.org/jira/browse/YARN-4925
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>              Labels: release-blocker
>             Fix For: 2.8.0, 3.0.0-alpha1
>
>         Attachments: 0001-YARN-4925.patch, 0002-YARN-4925.patch, YARN-4925-branch-2.7.001.patch
>
>
> Currently with nodelabel AMRMClient will not be able to specify nodelabels with Node/Rack
requests.For application like spark NODE_LOCAL requests cannot be asked with label expression.
> As per the check in  {{AMRMClientImpl#checkNodeLabelExpression}}
> {noformat}
>     // Don't allow specify node label against ANY request
>     if ((containerRequest.getRacks() != null && 
>         (!containerRequest.getRacks().isEmpty()))
>         || 
>         (containerRequest.getNodes() != null && 
>         (!containerRequest.getNodes().isEmpty()))) {
>       throw new InvalidContainerRequestException(
>           "Cannot specify node label with rack and node");
>     }
> {noformat}
> {{AppSchedulingInfo#updateResourceRequests}} we do reset of labels to that of OFF-SWITCH.

> The above check is not required for ContainerRequest ask /cc [~wangda] thank you for
confirming



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message