Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 12 Apr 2017 15:46:42 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13061862.1491424967000.266646.1492012002138@Atlassian.JIRA>
In-Reply-To: <JIRA.13061862.1491424967000@Atlassian.JIRA>
References: <JIRA.13061862.1491424967000@Atlassian.JIRA> <JIRA.13061862.1491424967177@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-6450) TestContainerManagerWithLCE requires
 override for each new test added to ContainerManagerTest
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 12 Apr 2017 15:46:48 -0000


    [ https://issues.apache.org/jira/browse/YARN-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966085#comment-15966085 ] 

Hudson commented on YARN-6450:
------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11576 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11576/])
YARN-6450. TestContainerManagerWithLCE requires override for each new (epayne: rev a16ab2be91e29f0aa4ad3488d35977cb5d1e1f5c)
* (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestContainerManagerWithLCE.java


> TestContainerManagerWithLCE requires override for each new test added to ContainerManagerTest
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-6450
>                 URL: https://issues.apache.org/jira/browse/YARN-6450
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>             Fix For: 2.9.0, 3.0.0-alpha3
>
>         Attachments: YARN-6450.001.patch
>
>
> Every test in TestContainerManagerWithLCE looks like this:
> {code}
>   @Override
>   public void testSomething() throws Exception {
>     // Don't run the test if the binary is not available.
>     if (!shouldRunTest()) {
>       LOG.info("LCE binary path is not passed. Not running the test");
>       return;
>     }
>     LOG.info("Running something");
>     super.testSomething();
>   }
> {code}
> If  a new test is added to ContainerManagerTest then by default ContainerManagerTestWithLCE will fail when the LCE has not been configured.  This is an unnecessary maintenance burden.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org