Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 940C5200C4C for ; Tue, 4 Apr 2017 22:44:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 928CA160B77; Tue, 4 Apr 2017 20:44:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D7416160B90 for ; Tue, 4 Apr 2017 22:44:44 +0200 (CEST) Received: (qmail 2490 invoked by uid 500); 4 Apr 2017 20:44:44 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 2479 invoked by uid 99); 4 Apr 2017 20:44:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Apr 2017 20:44:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 987C318063D for ; Tue, 4 Apr 2017 20:44:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 8jj1tq44tvMj for ; Tue, 4 Apr 2017 20:44:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C75835F24C for ; Tue, 4 Apr 2017 20:44:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5AA42E0D20 for ; Tue, 4 Apr 2017 20:44:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AEC0524021 for ; Tue, 4 Apr 2017 20:44:41 +0000 (UTC) Date: Tue, 4 Apr 2017 20:44:41 +0000 (UTC) From: "Miklos Szegedi (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (YARN-6438) Code can be improved in ContainersMonitorImpl.java MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 04 Apr 2017 20:44:45 -0000 Miklos Szegedi created YARN-6438: ------------------------------------ Summary: Code can be improved in ContainersMonitorImpl.java Key: YARN-6438 URL: https://issues.apache.org/jira/browse/YARN-6438 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: Miklos Szegedi Priority: Minor I noticed two code blocks that can be improved in ContainersMonitorImpl.java. cpuUsagePercentPerCoreByAllContainers and cpuUsageTotalCoresByAllContainers track the same value and CHANGE_MONITORING_CONTAINER_RESOURCE is checked twice along with two calls to changeContainerResource. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org