Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 24 Apr 2017 23:57:04 +0000 (UTC)
From: "Vinod Kumar Vavilapalli (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13043431.1487205924000.39607.1493078224125@Atlassian.JIRA>
In-Reply-To: <JIRA.13043431.1487205924000@Atlassian.JIRA>
References: <JIRA.13043431.1487205924000@Atlassian.JIRA> <JIRA.13043431.1487205924677@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-6202) Configuration item
 Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY is disregarded
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 24 Apr 2017 23:57:08 -0000


    [ https://issues.apache.org/jira/browse/YARN-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982137#comment-15982137 ] 

Vinod Kumar Vavilapalli commented on YARN-6202:
-----------------------------------------------

bq. Option 1 sounds good to me. Any thoughts? Vinod Kumar Vavilapalli
bq. I saw other projects use these configuration items, better to not commit this to branch2.
bq. Agree. An example is: TEZ-2049. Let's keep the patch in trunk only.
Folks, a bunch of downstream are using this. This is not the kind of cleanup that will balance out code-cleanup vs downstream pain. Let's just revert the removals in the patch and instead deprecate the config as well as the constants.


> Configuration item Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY is disregarded
> -------------------------------------------------------------------------
>
>                 Key: YARN-6202
>                 URL: https://issues.apache.org/jira/browse/YARN-6202
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager, resourcemanager
>    Affects Versions: 2.9.0, 3.0.0-alpha2
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>             Fix For: 3.0.0-alpha3
>
>         Attachments: YARN-6202.001.patch, YARN-6202.002.patch, YARN-6202.003.patch, YARN-6202.004.patch
>
>
> Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY (yarn.dispatcher.exit-on-error) always be true no matter what value in configuration files. This misleads users. Two solutions: 
> # Remove the configuration item and provide a method to allow {{exitOnDispatchException}}/{{shouldExitOnError}} to be false to enable related unit tests. There is no need for false value in a real daemon since daemons should crash if its dispatcher quit.
> # Make it default true instead of false, so that we don't need to hard code it to be true in RM and NM, it is still configurable, and also provide method to enable related unit tests.
> Other than that, the code around it needs to refactor. {{public static final}} for a variable of interface isn't necessary, and YARN related configure item should be in class YarnConfiguration. 


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org