hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-6450) TestContainerManagerWithLCE requires override for each new test added to ContainerManagerTest
Date Wed, 05 Apr 2017 20:44:41 GMT

     [ https://issues.apache.org/jira/browse/YARN-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Lowe updated YARN-6450:
-----------------------------
    Attachment: YARN-6450.001.patch

Using {{Assume.assumeTrue(shouldRunTest())}} in the existing setup function will automatically
skip the tests if the LCE hasn't been configured.  Then we don't need to revisit this code
every time a new unit test is added to ContainerManagerTest.

Attaching a patch that implements this approach.

> TestContainerManagerWithLCE requires override for each new test added to ContainerManagerTest
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-6450
>                 URL: https://issues.apache.org/jira/browse/YARN-6450
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: YARN-6450.001.patch
>
>
> Every test in TestContainerManagerWithLCE looks like this:
> {code}
>   @Override
>   public void testSomething() throws Exception {
>     // Don't run the test if the binary is not available.
>     if (!shouldRunTest()) {
>       LOG.info("LCE binary path is not passed. Not running the test");
>       return;
>     }
>     LOG.info("Running something");
>     super.testSomething();
>   }
> {code}
> If  a new test is added to ContainerManagerTest then by default ContainerManagerTestWithLCE
will fail when the LCE has not been configured.  This is an unnecessary maintenance burden.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message