hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6438) Code can be improved in ContainersMonitorImpl.java
Date Wed, 12 Apr 2017 22:53:43 GMT

    [ https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966771#comment-15966771
] 

Daniel Templeton commented on YARN-6438:
----------------------------------------

Thanks for the patch, [~miklos.szegedi@cloudera.com].  A couple of minor comments:

You only partially deleted the comment about example 6 machines, so it's left with a dangling
"and".

Also, you copied the comment further down in the code, so (at least part of) it is in their
twice.  Did you mean to move it instead?

> Code can be improved in ContainersMonitorImpl.java
> --------------------------------------------------
>
>                 Key: YARN-6438
>                 URL: https://issues.apache.org/jira/browse/YARN-6438
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Miklos Szegedi
>            Assignee: Miklos Szegedi
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-6438.000.patch, YARN-6438.001.patch, YARN-6438.002.patch
>
>
> I noticed two code blocks that can be improved in ContainersMonitorImpl.java.  cpuUsagePercentPerCoreByAllContainers
and cpuUsageTotalCoresByAllContainers track the same value and CHANGE_MONITORING_CONTAINER_RESOURCE
is checked twice along with two calls to changeContainerResource.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message