hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miklos Szegedi (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-6423) Queue metrics doesn't work for Fair Scheduler in SLS
Date Tue, 04 Apr 2017 22:15:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955933#comment-15955933
] 

Miklos Szegedi edited comment on YARN-6423 at 4/4/17 10:15 PM:
---------------------------------------------------------------

Thank you for the patch [~yufeigu].
I have a few comments.
{{String getRealQueueName(String queue) throws Exception;}} It is usually a better design
to use a derived Exception class like YarnException.
I suggest the following message: {{Can't find the queue by the given name}}.
I see camel case more often in the code: {{baselineTimeMs}}
{{private void createAMForJob(Map jsonJob) throws Exception}} I would use an SLSException
or YarnException here.
It is probably shorter to use a get, put 1 if null and do the update instead of containsKey
{code}
469	    if (!queueAppNumMap.containsKey(queueName)) {
470	      queueAppNumMap.put(queueName, 1);
471	    } else {
472	      queueAppNumMap.put(queueName, queueAppNumMap.get(queueName) + 1);
473	    }
{code}
{{newAndRunAM}} How about {{runNewAM}}?
{{updateQueueAppNum}} How about {{increaseQueueAppNum}}?


was (Author: miklos.szegedi@cloudera.com):
Thank you for the patch [~yufeigu].
I have a few comments.
{{String getRealQueueName(String queue) throws Exception;}} It is usually a better design
to use a derived Exception class like YarnException.
I suggest the following message: {{Can't find the queue by the given name}}.
I see camel case more often in the code: {{baselineTimeMs}}
{{private void createAMForJob(Map jsonJob) throws Exception}} I would use an SLSException
or YarnException here.
It is probably shorter to use a get, put 1 if null and do the update instead of containsKey
{code}
469	    if (!queueAppNumMap.containsKey(queueName)) {
470	      queueAppNumMap.put(queueName, 1);
471	    } else {
472	      queueAppNumMap.put(queueName, queueAppNumMap.get(queueName) + 1);
473	    }
{code}
{{newAndRunAM}} How about {{runNewAM}}?

> Queue metrics doesn't work for Fair Scheduler in SLS
> ----------------------------------------------------
>
>                 Key: YARN-6423
>                 URL: https://issues.apache.org/jira/browse/YARN-6423
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler-load-simulator
>    Affects Versions: 2.9.0, 3.0.0-alpha2
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-6423.001.patch
>
>
> Queue allocated memory and vcores always be 0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message