hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roni Burd (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6245) Add FinalResource object to reduce overhead of Resource class instancing
Date Tue, 04 Apr 2017 18:40:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955593#comment-15955593
] 

Roni Burd commented on YARN-6245:
---------------------------------

I agree. The scheduler should use only LightResource only. In addition to that, I've found
that even if you use LightResource the scheduler are instantiating too many objects so my
change also modify ResourceCalculator (and some inherited methods) in order to reuse a LightResource
(especially in methods like getUserLimitAndSetHeadroom() and other methods. 

So my question should I submit both changes in one patch?


> Add FinalResource object to reduce overhead of Resource class instancing
> ------------------------------------------------------------------------
>
>                 Key: YARN-6245
>                 URL: https://issues.apache.org/jira/browse/YARN-6245
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>         Attachments: observable-resource.patch, YARN-6245.preliminary-staled.1.patch
>
>
> There're lots of Resource object creation in YARN Scheduler, since Resource object is
backed by protobuf, creation of such objects is expensive and becomes bottleneck.
> To address the problem, we can introduce a FinalResource (Is it better to call it ImmutableResource?)
object, which is not backed by PBImpl. We can use this object in frequent invoke paths in
the scheduler.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message