hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yufei Gu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6202) Configuration item Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY is disregarded
Date Mon, 03 Apr 2017 18:23:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953948#comment-15953948
] 

Yufei Gu commented on YARN-6202:
--------------------------------

It won't hide code bugs since the unit tests won't pass if AsyncDispatcher crashed. People
who use AsyncDispatcher assume it crash on exceptions. Hiding this is more dangerous by making
it false by default.

> Configuration item Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY is disregarded
> -------------------------------------------------------------------------
>
>                 Key: YARN-6202
>                 URL: https://issues.apache.org/jira/browse/YARN-6202
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager, resourcemanager
>    Affects Versions: 2.9.0, 3.0.0-alpha2
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-6202.001.patch, YARN-6202.002.patch
>
>
> Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY (yarn.dispatcher.exit-on-error) always be true
no matter what value in configuration files. This misleads users. Two solutions: 
> # Remove the configuration item and provide a method to allow {{exitOnDispatchException}}/{{shouldExitOnError}}
to be false to enable related unit tests. There is no need for false value in a real daemon
since daemons should crash if its dispatcher quit.
> # Make it default true instead of false, so that we don't need to hard code it to be
true in RM and NM, it is still configurable, and also provide method to enable related unit
tests.
> Other than that, the code around it needs to refactor. {{public static final}} for a
variable of interface isn't necessary, and YARN related configure item should be in class
YarnConfiguration. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message