hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6195) Export UsedCapacity and AbsoluteUsedCapacity to JMX
Date Fri, 07 Apr 2017 15:48:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960991#comment-15960991
] 

Jason Lowe commented on YARN-6195:
----------------------------------

Thanks for updating the patch!  At first I thought we had a potential for an NPE in CSQueueUtils
since there's this comment at the top:
{code}
  /**
   * Update partitioned resource usage, if nodePartition == null, will update
   * used resource for all partitions of this queue.
   */
  public static void updateUsedCapacity(final ResourceCalculator rc,
{code}

However in practice all the callers translate a null label to the no label enum so we're good.
 Looks like we'd have NPE problems even before this patch if nodePartition really was null,
so that's a bad comment unrelated to this patch.

+1 for the latest patch.  I'll commit this early next week if there are no objections.

> Export UsedCapacity and AbsoluteUsedCapacity to JMX
> ---------------------------------------------------
>
>                 Key: YARN-6195
>                 URL: https://issues.apache.org/jira/browse/YARN-6195
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacityscheduler, metrics, yarn
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Benson Qiu
>            Assignee: Benson Qiu
>         Attachments: YARN-6195.001.patch, YARN-6195.002.patch, YARN-6195.003.patch, YARN-6195.004.patch,
YARN-6195.005.patch
>
>
> `usedCapacity` and `absoluteUsedCapacity` are currently not available as JMX. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message