hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Payne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5994) TestCapacityScheduler.testAMLimitUsage fails intermittently
Date Fri, 14 Apr 2017 14:23:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-5994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969087#comment-15969087
] 

Eric Payne commented on YARN-5994:
----------------------------------

Thanks [~ebadger] for reporting and fixing this issue.

The only thing I found is that the patch does not build in branch-2 or branch-2.8 because
the anonymous inner class returned by {{GenericTestUtils.waitFor}} in {{TestCapacityScheduler#verifyAMLimitForLeafQueue}}
uses both of the {{nodeMemory}} and {{scheduler}} local variables. Since both branch-2 and
branch-2.8 are compiling with java 2.7, these variables need to be final.

The patch looks good to me. I give my +1. I will commit this soon if there are no objections,
and I will fix the {{final}} issues as part of the backport to branch-2 and branch-2.8.

> TestCapacityScheduler.testAMLimitUsage fails intermittently
> -----------------------------------------------------------
>
>                 Key: YARN-5994
>                 URL: https://issues.apache.org/jira/browse/YARN-5994
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>         Attachments: org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler-output.txt,
YARN-5994.001.patch
>
>
> {noformat}
> java.lang.AssertionError: app shouldn't be null
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.assertTrue(Assert.java:41)
> 	at org.junit.Assert.assertNotNull(Assert.java:621)
> 	at org.apache.hadoop.yarn.server.resourcemanager.MockRM.waitForState(MockRM.java:169)
> 	at org.apache.hadoop.yarn.server.resourcemanager.MockRM.submitApp(MockRM.java:577)
> 	at org.apache.hadoop.yarn.server.resourcemanager.MockRM.submitApp(MockRM.java:488)
> 	at org.apache.hadoop.yarn.server.resourcemanager.MockRM.submitApp(MockRM.java:395)
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler.verifyAMLimitForLeafQueue(TestCapacityScheduler.java:3389)
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler.testAMLimitUsage(TestCapacityScheduler.java:3251)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message