hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manikandan R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3839) Quit throwing NMNotYetReadyException
Date Tue, 18 Apr 2017 18:13:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973202#comment-15973202
] 

Manikandan R commented on YARN-3839:
------------------------------------

[~jlowe], [~jianhe] Thanks for your suggestions.

Attaching patch for review. I've made the changes based on our earlier conversations - mostly
code cleanup and its corresponding test cases etc. As part of this, TestNodeManagerResync#testBlockNewContainerRequestsOnStartAndResync()
also has been cleaned up. Given this, Is it better to write new test cases to validate the
code (as some other exception would be thrown while NM is restarting. For ex, InvalidToken
exception would be thrown instead of NMNotYeadyException) based on new patch? Please review
and let me know your comments.

> Quit throwing NMNotYetReadyException
> ------------------------------------
>
>                 Key: YARN-3839
>                 URL: https://issues.apache.org/jira/browse/YARN-3839
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Karthik Kambatla
>            Assignee: Manikandan R
>         Attachments: YARN-3839.001.patch
>
>
> Quit throwing NMNotYetReadyException when NM has not yet registered with the RM.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message