Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 29 Mar 2017 23:02:41 +0000 (UTC)
From: "Haibo Chen (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13056231.1489569791000.159575.1490828561664@Atlassian.JIRA>
In-Reply-To: <JIRA.13056231.1489569791000@Atlassian.JIRA>
References: <JIRA.13056231.1489569791000@Atlassian.JIRA> <JIRA.13056231.1489569791755@jira-lw-us.apache.org>
Subject: [jira] [Updated] (YARN-6342) Make TimelineV2Client's drain timeout
 after stop configurable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 29 Mar 2017 23:02:46 -0000


     [ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Haibo Chen updated YARN-6342:
-----------------------------
    Attachment: YARN-6342.01.patch

> Make TimelineV2Client's drain timeout after stop configurable
> -------------------------------------------------------------
>
>                 Key: YARN-6342
>                 URL: https://issues.apache.org/jira/browse/YARN-6342
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Haibo Chen
>         Attachments: YARN-6342.00.patch, YARN-6342.01.patch
>
>
> Found these with [~rohithsharma] while browsing the code
> - In stop: it calls shutdownNow which doens't wait for pending tasks, should it use shutdown instead ?
> {code}
>     public void stop() {
>       LOG.info("Stopping TimelineClient.");
>       executor.shutdownNow();
>       try {
>         executor.awaitTermination(DRAIN_TIME_PERIOD, TimeUnit.MILLISECONDS);
>       } catch (InterruptedException e) {
> {code}
> - In TimelineClientImpl#createRunnable:
> If any exception happens when publish one entity (publishWithoutBlockingOnQueue), the thread exists. I think it should try best effort to continue publishing the timeline entities, one failure should not cause all followup entities not published.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org