Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 15 Mar 2017 20:05:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13017808.1478205878000.30587.1489608341996@Atlassian.JIRA>
In-Reply-To: <JIRA.13017808.1478205878000@Atlassian.JIRA>
References: <JIRA.13017808.1478205878000@Atlassian.JIRA> <JIRA.13017808.1478205878441@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-5829) FS preemption should reserve a node
 before considering containers on it for preemption
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 15 Mar 2017 20:05:54 -0000


    [ https://issues.apache.org/jira/browse/YARN-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926872#comment-15926872 ] 

ASF GitHub Bot commented on YARN-5829:
--------------------------------------

Github user szegedim commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/201#discussion_r106269539
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java ---
    @@ -118,23 +178,56 @@ synchronized FSAppAttempt getReservedAppSchedulable() {
        *
        * @param containers container to mark
        */
    -  void addContainersForPreemption(Collection<RMContainer> containers) {
    -    containersForPreemption.addAll(containers);
    +  void addContainersForPreemption(Collection<RMContainer> containers,
    +                                  FSAppAttempt appAttempt) {
    +    for(RMContainer container : containers) {
    +      containersForPreemption.put(container, appAttempt);
    --- End diff --
    
    Done.


> FS preemption should reserve a node before considering containers on it for preemption
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-5829
>                 URL: https://issues.apache.org/jira/browse/YARN-5829
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Karthik Kambatla
>            Assignee: Miklos Szegedi
>
> FS preemption evaluates nodes for preemption, and subsequently preempts identified containers. If this node is not reserved for a specific application, any other application could be allocated resources on this node. 
> Reserving the node for the starved application before preempting containers would help avoid this.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org