Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 31 Mar 2017 01:17:42 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13017808.1478205878000.171065.1490923062105@Atlassian.JIRA>
In-Reply-To: <JIRA.13017808.1478205878000@Atlassian.JIRA>
References: <JIRA.13017808.1478205878000@Atlassian.JIRA> <JIRA.13017808.1478205878441@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-5829) FS preemption should reserve a node
 before considering containers on it for preemption
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 31 Mar 2017 01:17:47 -0000


    [ https://issues.apache.org/jira/browse/YARN-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950134#comment-15950134 ] 

ASF GitHub Bot commented on YARN-5829:
--------------------------------------

Github user kambatla commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/201#discussion_r109071718
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java ---
    @@ -987,10 +1010,16 @@ void attemptScheduling(FSSchedulerNode node) {
           }
     
           // Assign new containers...
    -      // 1. Check for reserved applications
    -      // 2. Schedule if there are no reservations
    -
    +      // 1. Ensure containers are assigned to the apps that preempted
    +      // 2. Check for reserved applications
    +      // 3. Schedule if there are no reservations
    +
    +      // Apps may wait for preempted containers
    +      // We have to satisfy these first to avoid cases, when we preempt
    +      // a container for A from B and C gets the preempted containers,
    +      // when C does not qualify for preemption itself.
           boolean validReservation = false;
    +      assignPreemptedContainers(node);
    --- End diff --
    
    Call to assignPreemptedContainers should go before declaring validReservation. 


> FS preemption should reserve a node before considering containers on it for preemption
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-5829
>                 URL: https://issues.apache.org/jira/browse/YARN-5829
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Karthik Kambatla
>            Assignee: Miklos Szegedi
>
> FS preemption evaluates nodes for preemption, and subsequently preempts identified containers. If this node is not reserved for a specific application, any other application could be allocated resources on this node. 
> Reserving the node for the starved application before preempting containers would help avoid this.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org