Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 22 Mar 2017 21:55:41 +0000 (UTC)
From: "Varun Saxena (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12980040.1466124032000.93750.1490219741706@Atlassian.JIRA>
In-Reply-To: <JIRA.12980040.1466124032000@Atlassian.JIRA>
References: <JIRA.12980040.1466124032000@Atlassian.JIRA> <JIRA.12980040.1466124032963@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (YARN-5269) Bubble exceptions and errors
 all the way up the calls, including to clients.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 22 Mar 2017 21:55:49 -0000


    [ https://issues.apache.org/jira/browse/YARN-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937223#comment-15937223 ] 

Varun Saxena edited comment on YARN-5269 at 3/22/17 9:54 PM:
-------------------------------------------------------------

We had actually discussed about TimelinePutResponse long before.
I think where we thought TimelinePutResponse will be useful is that in HBaseTimelineWriterImpl#write we write entities one by one. And it maybe possible that a set of writes are successful and another set is not.

But frankly writes are not persisted till flush is called, if buffer size is not exceeded.
Should we attempt a flush for sync put even if an exception occurs on write. Can a flush succeed in such a scenario?
cc [~vrushalic]


was (Author: varun_saxena):
We had actually discussed about TimelinePutResponse long before.
I think where we though TimelinePutResponse will be useful is that in HBaseTimelineWriterImpl#write we write entities one by one. And it maybe possible that a set of writes are successful and another set is not.

But frankly writes are not persisted till flush is called, if buffer size is not exceeded.
Should we attempt a flush for sync put even if an exception occurs on write. Can a flush succeed in such a scenario?
cc [~vrushalic]

> Bubble exceptions and errors all the way up the calls, including to clients.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-5269
>                 URL: https://issues.apache.org/jira/browse/YARN-5269
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Joep Rottinghuis
>            Assignee: Haibo Chen
>              Labels: YARN-5355, yarn-5355-merge-blocker
>
> Currently we ignore (swallow) exception from the HBase side in many cases (reads and writes).
> Also, on the client side, neither TimelineClient#putEntities (the v2 flavor) nor the #putEntitiesAsync method return any value.
> For the second drop we may want to consider how we properly bubble up exceptions throughout the write and reader call paths and if we want to return a response in putEntities and some future kind of result for putEntitiesAsync.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org