hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yufei Gu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6411) Clean up the overwrite of createDispatcher() in subclass of MockRM
Date Thu, 30 Mar 2017 20:34:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949756#comment-15949756
] 

Yufei Gu commented on YARN-6411:
--------------------------------

The test failure is unrelated. TestAMRMClient#testAMRMClientWithContainerResourceChange is
flaky locally both with and without my patch. And I think it's OK to leave the style issues
alone.

> Clean up the overwrite of createDispatcher() in subclass of MockRM
> ------------------------------------------------------------------
>
>                 Key: YARN-6411
>                 URL: https://issues.apache.org/jira/browse/YARN-6411
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: resourcemanager
>    Affects Versions: 2.9.0, 3.0.0-alpha2
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>            Priority: Minor
>         Attachments: YARN-6411.001.patch, YARN-6411.002.patch
>
>
> MockRM creates a object of {{DrainDispatcher}} in YARN-3102. We don't need to do the
same thing in its subclasses.
> {code}
>   @Override
>   protected Dispatcher createDispatcher() {
>     return new DrainDispatcher();
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message