hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tao Jie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6380) FSAppAttempt keeps redundant copy of the queue
Date Fri, 24 Mar 2017 03:24:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939735#comment-15939735
] 

Tao Jie commented on YARN-6380:
-------------------------------

[~templedf],  in current FSAppAttempt constructor´╝Ü
{code}
 public FSAppAttempt(FairScheduler scheduler,
      ApplicationAttemptId applicationAttemptId, String user, FSLeafQueue queue,
      ActiveUsersManager activeUsersManager, RMContext rmContext) {
    super(applicationAttemptId, user, queue, activeUsersManager, rmContext);

    this.scheduler = scheduler;
    this.fsQueue = queue;
    this.startTime = scheduler.getClock().getTime();
    this.lastTimeAtFairShare = this.startTime;
    this.appPriority = Priority.newInstance(1);
    this.resourceWeights = new ResourceWeights();
  }
{code}
It seems to me that we create another reference of queue rather than copy of the queue. So
I think both {{SchedulerApplicationAttempt#queue}} and {{SchedulerApplicationAttempt#queue}}
indicates to the same object. It ok to avoid redundant field in FSAppAttempt, but we should
convert Queue to FsQueue when using it.

> FSAppAttempt keeps redundant copy of the queue
> ----------------------------------------------
>
>                 Key: YARN-6380
>                 URL: https://issues.apache.org/jira/browse/YARN-6380
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>         Attachments: YARN-6380.001.patch
>
>
> The {{FSAppAttempt}} class defines its own {{fsQueue}} variable that is a second copy
of the {{SchedulerApplicationAttempt}}'s {{queue}} variable.  Aside from being redundant,
it's also a bug, because when moving applications, we only update the {{SchedulerApplicationAttempt}}'s
{{queue}}, not the {{FSAppAttempt}}'s {{fsQueue}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message