hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haibo Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6342) Issues in async API of TimelineClient
Date Mon, 20 Mar 2017 22:30:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933724#comment-15933724
] 

Haibo Chen commented on YARN-6342:
----------------------------------

publishWithoutBlockingOnQueue() will only throw InterruptedExceptions from calling queue.poll(),
which is already taken care of by the current code. EntitiesHolder.run() never throws an exception
based on FutureTask java doc and my little testing. Therefore, I think the publishing thread
never exits because of unexpected exceptions in publishing entities.

> Issues in async API of TimelineClient
> -------------------------------------
>
>                 Key: YARN-6342
>                 URL: https://issues.apache.org/jira/browse/YARN-6342
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Haibo Chen
>              Labels: yarn-5355-merge-blocker
>
> Found these with [~rohithsharma] while browsing the code
> - In stop: it calls shutdownNow which doens't wait for pending tasks, should it use shutdown
instead ?
> {code}
>     public void stop() {
>       LOG.info("Stopping TimelineClient.");
>       executor.shutdownNow();
>       try {
>         executor.awaitTermination(DRAIN_TIME_PERIOD, TimeUnit.MILLISECONDS);
>       } catch (InterruptedException e) {
> {code}
> - In TimelineClientImpl#createRunnable:
> If any exception happens when publish one entity (publishWithoutBlockingOnQueue), the
thread exists. I think it should try best effort to continue publishing the timeline entities,
one failure should not cause all followup entities not published.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message