hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Created] (YARN-6342) Issues in TimelineClientImpl#TimelineClientImpl
Date Wed, 15 Mar 2017 09:23:41 GMT
Jian He created YARN-6342:

             Summary: Issues in TimelineClientImpl#TimelineClientImpl 
                 Key: YARN-6342
                 URL: https://issues.apache.org/jira/browse/YARN-6342
             Project: Hadoop YARN
          Issue Type: Bug
            Reporter: Jian He

Found these with [~rohithsharma] while browsing the code
- In stop: it calls shutdownNow which doens't wait for pending tasks, should it use shutdown
instead ?
    public void stop() {
      LOG.info("Stopping TimelineClient.");
      try {
        executor.awaitTermination(DRAIN_TIME_PERIOD, TimeUnit.MILLISECONDS);
      } catch (InterruptedException e) {
{code }
- In createRunnable:
If any exception happens when publish one entity (ServiceTimelineEvent), the thread exists.
I think it should try best effort to continue publish the timeline events, one failure should
not cause all followup events not published.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message