hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6342) Make TimelineV2Client's drain timeout after stop configurable
Date Thu, 30 Mar 2017 05:53:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948462#comment-15948462
] 

Varun Saxena commented on YARN-6342:
------------------------------------

Sorry for nitpicking. 
I would gives spaces in between timelinev2client. And say draining "leftover entities" to
indicate we are talking about entities.

{code}
+    <description>
+    The time period for which timelinev2client will wait for draining its queue
+    after stop.
+    </description>
{code}

Let me invoke the build manually. Some failures look weird.

Regarding this being an advanced configuration, I felt upon offline discussion with Rohith
that it would be better to make this config public as in their testing they found entities
were taking upto 3 seconds to flush. So this would largely depend on AM and the amount of
entities they write on stop.  

> Make TimelineV2Client's drain timeout after stop configurable
> -------------------------------------------------------------
>
>                 Key: YARN-6342
>                 URL: https://issues.apache.org/jira/browse/YARN-6342
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Haibo Chen
>         Attachments: YARN-6342.00.patch, YARN-6342.01.patch
>
>
> Found these with [~rohithsharma] while browsing the code
> - In stop: it calls shutdownNow which doens't wait for pending tasks, should it use shutdown
instead ?
> {code}
>     public void stop() {
>       LOG.info("Stopping TimelineClient.");
>       executor.shutdownNow();
>       try {
>         executor.awaitTermination(DRAIN_TIME_PERIOD, TimeUnit.MILLISECONDS);
>       } catch (InterruptedException e) {
> {code}
> - In TimelineClientImpl#createRunnable:
> If any exception happens when publish one entity (publishWithoutBlockingOnQueue), the
thread exists. I think it should try best effort to continue publishing the timeline entities,
one failure should not cause all followup entities not published.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message