hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6329) Remove unnecessary TODO comment from AppLogAggregatorImpl.java
Date Wed, 29 Mar 2017 01:47:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946388#comment-15946388
] 

Akira Ajisaka commented on YARN-6329:
-------------------------------------

Committed this to trunk and branch-2. Thanks [~vbertschinger] for the contribution and thanks
[~haibochen] for the review.

> Remove unnecessary TODO comment from AppLogAggregatorImpl.java
> --------------------------------------------------------------
>
>                 Key: YARN-6329
>                 URL: https://issues.apache.org/jira/browse/YARN-6329
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.8.0
>            Reporter: Akira Ajisaka
>            Assignee: victor bertschinger
>            Priority: Minor
>              Labels: newbie
>             Fix For: 2.9.0, 3.0.0-alpha3
>
>         Attachments: YARN-6329.001.patch
>
>
> After YARN-3116, this TODO comment is unnecessary.
> {code}
>   // TODO: The condition: containerId.getId() == 1 to determine an AM container
>   // is not always true.
>   private boolean shouldUploadLogs(ContainerLogContext logContext) {
>     return logAggPolicy.shouldDoLogAggregation(logContext);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message