hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6327) Removing queues from CapacitySchedulerQueueManager and ParentQueue should be done with iterator
Date Mon, 13 Mar 2017 19:51:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922832#comment-15922832
] 

Naganarasimha G R commented on YARN-6327:
-----------------------------------------

Thanks for working on this [~jhung], 
but java's foreach loop makes use of iterator internally and in general queue refresh is single
threaded operation hence remove operation is also not a risk. But agree its generally good
to use iterator and delete using the iterator. 
Hence i am ok with committing the patch but with reduced severity and also unmarking YARN-5556
as breaking this jira. Thoughts ?

> Removing queues from CapacitySchedulerQueueManager and ParentQueue should be done with
iterator
> -----------------------------------------------------------------------------------------------
>
>                 Key: YARN-6327
>                 URL: https://issues.apache.org/jira/browse/YARN-6327
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler
>            Reporter: Jonathan Hung
>            Assignee: Jonathan Hung
>         Attachments: YARN-6327.001.patch, YARN-6327.002.patch
>
>
> e.g. in {{CapacitySchedulerQueueManager}} {noformat}    for (Map.Entry<String, CSQueue>
e : existingQueues.entrySet()) {
>       String queueName = e.getKey();
>       if (!newQueues.containsKey(queueName)) {
>         existingQueues.remove(queueName);
>       }
>     }{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message