hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yufei Gu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6299) FairSharePolicy is incorrect when demand is less than min share
Date Wed, 08 Mar 2017 17:48:37 GMT

    [ https://issues.apache.org/jira/browse/YARN-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901645#comment-15901645
] 

Yufei Gu commented on YARN-6299:
--------------------------------

It makes sense to me that an app is always needy when its demand is less than min share. [~templedf],
can you elaborate your concern?

> FairSharePolicy is incorrect when demand is less than min share
> ---------------------------------------------------------------
>
>                 Key: YARN-6299
>                 URL: https://issues.apache.org/jira/browse/YARN-6299
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Daniel Templeton
>
> {code}
>       Resource resourceUsage1 = s1.getResourceUsage();
>       Resource resourceUsage2 = s2.getResourceUsage();
>       Resource minShare1 = Resources.min(RESOURCE_CALCULATOR, null,
>           s1.getMinShare(), s1.getDemand());
>       Resource minShare2 = Resources.min(RESOURCE_CALCULATOR, null,
>           s2.getMinShare(), s2.getDemand());
>       boolean s1Needy = Resources.lessThan(RESOURCE_CALCULATOR, null,
>           resourceUsage1, minShare1);
>       boolean s2Needy = Resources.lessThan(RESOURCE_CALCULATOR, null,
>           resourceUsage2, minShare2);
>       minShareRatio1 = (double) resourceUsage1.getMemorySize()
>           / Resources.max(RESOURCE_CALCULATOR, null, minShare1, ONE).getMemorySize();
>       minShareRatio2 = (double) resourceUsage2.getMemorySize()
>           / Resources.max(RESOURCE_CALCULATOR, null, minShare2, ONE).getMemorySize();
> {code}
> If demand is less than min share, then an app will be flagged as needy if it has demand
that is higher than its usage, which happens any time the app has been assigned resources
that it hasn't started using yet.  That sounds wrong to me.  [~kasha], [~yufeigu]?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message