hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6263) NMTokenSecretManagerInRM.createAndGetNMToken is not thread safe
Date Thu, 02 Mar 2017 17:29:45 GMT

    [ https://issues.apache.org/jira/browse/YARN-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892647#comment-15892647
] 

Jason Lowe commented on YARN-6263:
----------------------------------

+1 lgtm.  The unit test failures do not appear to be related, and the tests pass locally for
me with the patch applied.  I'll commit this tomorrow if there are no objections.

> NMTokenSecretManagerInRM.createAndGetNMToken is not thread safe
> ---------------------------------------------------------------
>
>                 Key: YARN-6263
>                 URL: https://issues.apache.org/jira/browse/YARN-6263
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>         Attachments: YARN-6263.01.patch
>
>
> NMTokenSecretManagerInRM.createAndGetNMToken modifies values of a ConcurrentHashMap,
which are of type HashTable, but it only acquires read lock.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message