hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-6256) Add FROM_ID info key for timeline entities in reader response.
Date Fri, 03 Mar 2017 20:12:45 GMT

    [ https://issues.apache.org/jira/browse/YARN-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894962#comment-15894962
] 

Varun Saxena edited comment on YARN-6256 at 3/3/17 8:12 PM:
------------------------------------------------------------

Thanks [~rohithsharma] for the patch.

It looks pretty close. A couple of nits.
# When we are encoding and decoding as strings, app ids', flow run id, etc. cannot have separator
char i.e."!". So the static block in TestRowKeysAsString is not required. It was required
in TestRowKeys because when we convert long / int to bytes it may have same byte sequence
as separator char so that had to be tested. In TestRowKeysAsString we can use any fixed flow
run ID and App ID. We do not need to use Separator#QUALIFIERS in the test class as well.
# There are changes in TimelineEntityFilters javadoc which is not really necessary. It is
there due to some line formatting. This unnecessarily increases size of the patch. If possible
exclude these changes.
# In testEntityRowKey better to use separator and escape char constants.

Other than this, it looks fine. Checkstyle need not be fixed.


was (Author: varun_saxena):
Thanks [~rohithsharma] for the patch.

It looks pretty close. A couple of nits.
# When we are encoding and decoding as strings, app ids', flow run id, etc. cannot have separator
char i.e."!". So the static block in TestRowKeysAsString is not required. It was required
in TestRowKeys because when we convert long / int to bytes it may have same byte sequence
as separator char so that had to be tested. In TestRowKeysAsString we can use any fixed flow
run ID and App ID. We do not need to use Separator#QUALIFIERS in the test class as well.
# There are changes in TimelineEntityFilters javadoc which is not really necessary. It is
there due to some line formatting. This unnecessarily increases size of the patch. If possible
exclude these changes.

Other than this, it looks fine. Checkstyle need not be fixed.

> Add FROM_ID info key for timeline entities in reader response. 
> ---------------------------------------------------------------
>
>                 Key: YARN-6256
>                 URL: https://issues.apache.org/jira/browse/YARN-6256
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-6256-YARN-5355.0001.patch, YARN-6256-YARN-5355.0002.patch
>
>
> It is continuation with YARN-6027 to add FROM_ID key in all other timeline entity responses
which includes
> # Flow run entity response. 
> # Application entity response
> # Generic timeline entity response - Here we need to retrospect on idprefix filter which
is now separately provided. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message