hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohith Sharma K S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6256) Add FROM_ID info key for timeline entities in reader response.
Date Fri, 03 Mar 2017 05:58:45 GMT

    [ https://issues.apache.org/jira/browse/YARN-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893779#comment-15893779
] 

Rohith Sharma K S commented on YARN-6256:
-----------------------------------------

bq. I do have another question (which also applies to YARN-6027). It seems that we're embedding
the FROMID value for every single entity we return. Would it be possible to do this only for
the "last" entity that gets returned if we're returning multiple entities? This might be a
secondary optimization, but for all other entities but the last, the FROMID value would be
ignored. In that sense, it would simply add to the payload size without providing benefits.
Thoughts?
Actually this one of the point I was thought some time during YARN-6027. There are couple
of points
# Consistency : when we retrieve multiple entities default template of entities should contains
FROM_ID otherwise it creates a confusion to the user and also makes user to think that it
is a bug at least in first observation.
# Another advantage is, UI will have option to pick up FROM_ID from any entities. 
# May be we can skip for single entity reader. I do not see any valid reason to add in single
entity retrieval.
# Regarding payload issue, I do not think adding FROM_ID field causes bigger impact on payload
size since its size is very less. However I am not come across any issue earlier with respect
to payload size, would you mind elaborating more on what would go wrong in production cluster.?
IIUC, the amount of data retrieved will increase by x-factor. But I believe x-factor is very
small. 

> Add FROM_ID info key for timeline entities in reader response. 
> ---------------------------------------------------------------
>
>                 Key: YARN-6256
>                 URL: https://issues.apache.org/jira/browse/YARN-6256
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-6256-YARN-5355.0001.patch
>
>
> It is continuation with YARN-6027 to add FROM_ID key in all other timeline entity responses
which includes
> # Flow run entity response. 
> # Application entity response
> # Generic timeline entity response - Here we need to retrospect on idprefix filter which
is now separately provided. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message