hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6164) Expose maximum-am-resource-percent in YarnClient
Date Wed, 29 Mar 2017 09:46:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946835#comment-15946835
] 

Sunil G commented on YARN-6164:
-------------------------------

Thanks [~benson.qiu] for the updated patch.

Few minor comments

# {{QueueConfigurations}} and {{QueueConfigurationsPBImpl}} does not have Apache license header.
Please add the same. This was the reason for ASF License red failure in jenkins.
# Test failure seems random. YARN-5652 is already raised for that. Hence its wont be a problem
from your patch.
# Could you please check *checkstyle* failures from jenkins. Some comments looks good to be
fixed in that. (like unused imports). Whichever could be fixed and possible, you could give
a try.
# In {{yarn_protos.proto}} for * QueueConfigurationsMapProto*, {{QueueConfigurationsProto}}
could be made optional.
# In {{QueueConfigurationsPBImpl.java}}, *setCapacity* seems not override. Its commented,
is it intended?

I think rest all changes looks fine. Thank You.

> Expose maximum-am-resource-percent in YarnClient
> ------------------------------------------------
>
>                 Key: YARN-6164
>                 URL: https://issues.apache.org/jira/browse/YARN-6164
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.7.2
>            Reporter: Benson Qiu
>            Assignee: Benson Qiu
>         Attachments: YARN-6164.001.patch, YARN-6164.002.patch, YARN-6164.003.patch, YARN-6164.004.patch,
YARN-6164.005.patch, YARN-6164.006.patch, YARN-6164.007.patch
>
>
> `yarn.scheduler.capacity.maximum-am-resource-percent` is exposed through the [Cluster
Scheduler API|http://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/ResourceManagerRest.html#Cluster_Scheduler_API],
but not through [YarnClient|https://hadoop.apache.org/docs/current/api/org/apache/hadoop/yarn/client/api/YarnClient.html].
> Since YarnClient and RM REST APIs depend on different ports (8032 vs 8088 by default),
it would be nice to expose `maximum-am-resource-percent` in YarnClient as well. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message