hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6146) Add Builder methods for TimelineEntityFilters
Date Thu, 16 Mar 2017 17:15:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928452#comment-15928452
] 

Varun Saxena commented on YARN-6146:
------------------------------------

Thanks [~haibochen] for the patch. Looks straightforward. Couple of comments.

# In TimelineReaderWebServicesUtils, why not use the builder in existing createTimelineEntityFilters
method. Why create a new one?
# Seems some of the checkstyle issues can be fixed
# In Builder maybe rename fromid to fromId


> Add Builder methods for TimelineEntityFilters
> ---------------------------------------------
>
>                 Key: YARN-6146
>                 URL: https://issues.apache.org/jira/browse/YARN-6146
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Rohith Sharma K S
>            Assignee: Haibo Chen
>         Attachments: YARN-6146.01.patch, YARN-6146.02.patch, YARN-6146-YARN-5355.01.patch,
YARN-6146-YARN-5355.02.patch
>
>
> The timeline filters are evolving and can be add more and more filters. It is better
to start using Builder methods rather than changing constructor every time for adding new
filters. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message