hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5829) FS preemption should reserve a node before considering containers on it for preemption
Date Tue, 28 Mar 2017 19:56:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945823#comment-15945823
] 

ASF GitHub Bot commented on YARN-5829:
--------------------------------------

Github user kambatla commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/201#discussion_r108519744
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
---
    @@ -130,11 +200,47 @@ void addContainersForPreemption(Collection<RMContainer> containers)
{
       }
     
       /**
    -   * Remove container from the set of containers marked for preemption.
    -   *
    -   * @param container container to remove
    +   * The Scheduler has allocated containers on this node to the given
    +   * application.
    +   * @param rmContainer Allocated container
    +   * @param launchedOnNode True if the container has been launched
    +   */
    +  @Override
    +  protected synchronized void allocateContainer(RMContainer rmContainer,
    +                                                boolean launchedOnNode) {
    +    super.allocateContainer(rmContainer, launchedOnNode);
    +    Resource allocated = rmContainer.getAllocatedResource();
    +    if (!Resources.isNone(allocated)) {
    --- End diff --
    
    Will we have an empty allocation? If not, should we log an error when we do. 


> FS preemption should reserve a node before considering containers on it for preemption
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-5829
>                 URL: https://issues.apache.org/jira/browse/YARN-5829
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Karthik Kambatla
>            Assignee: Miklos Szegedi
>
> FS preemption evaluates nodes for preemption, and subsequently preempts identified containers.
If this node is not reserved for a specific application, any other application could be allocated
resources on this node. 
> Reserving the node for the starved application before preempting containers would help
avoid this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message