hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5829) FS preemption should reserve a node before considering containers on it for preemption
Date Sat, 25 Mar 2017 01:05:43 GMT

    [ https://issues.apache.org/jira/browse/YARN-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941418#comment-15941418
] 

ASF GitHub Bot commented on YARN-5829:
--------------------------------------

Github user kambatla commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/201#discussion_r108020399
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java
---
    @@ -18,18 +18,27 @@
     
     package org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair;
     
    +import com.google.common.annotations.VisibleForTesting;
     import org.apache.commons.logging.Log;
     import org.apache.commons.logging.LogFactory;
     import org.apache.hadoop.classification.InterfaceAudience.Private;
     import org.apache.hadoop.classification.InterfaceStability.Unstable;
     import org.apache.hadoop.yarn.api.records.ApplicationAttemptId;
    +import org.apache.hadoop.yarn.api.records.ContainerId;
    +import org.apache.hadoop.yarn.api.records.Resource;
     import org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainer;
     import org.apache.hadoop.yarn.server.resourcemanager.rmnode.RMNode;
     import org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt;
     import org.apache.hadoop.yarn.server.scheduler.SchedulerRequestKey;
     import org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerNode;
    +import org.apache.hadoop.yarn.util.resource.Resources;
     
     import java.util.Collection;
    +import java.util.Comparator;
    +import java.util.Iterator;
    +import java.util.LinkedHashMap;
    +import java.util.LinkedHashSet;
    --- End diff --
    
    Don't think we are using this import anymore. 


> FS preemption should reserve a node before considering containers on it for preemption
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-5829
>                 URL: https://issues.apache.org/jira/browse/YARN-5829
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Karthik Kambatla
>            Assignee: Miklos Szegedi
>
> FS preemption evaluates nodes for preemption, and subsequently preempts identified containers.
If this node is not reserved for a specific application, any other application could be allocated
resources on this node. 
> Reserving the node for the starved application before preempting containers would help
avoid this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message