hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Po (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5331) Extend RLESparseResourceAllocation with period for supporting recurring reservations in YARN ReservationSystem
Date Thu, 23 Mar 2017 19:36:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-5331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939094#comment-15939094
] 

Sean Po commented on YARN-5331:
-------------------------------

Thanks [~ajsangeetha] for the update, a few more comments:
* It may be more appropriate to log instead of printing to stdout using System.out.println.
(PeriodicRLESparseResourceAllocation.java+84,99)
* NIT: PeriodicRLESparseResourceAllocation::removeInterval does not have the same checks for
time interval that PeriodicRLESparseResourceAllocation::setCapacityInInterval does.
* We have checks in PeriodicRLESparseResourceAllocation::setCapacityInInterval and PeriodicRLESparseResourceAllocation::removeInterval
that will prevent the capacity from being added or removed. Can we verify these checks by
adding test cases that would fail to be added or removed?
* Would it be better to have PeriodicRLESparseResourceAllocation::setCapacityInInterval or
PeriodicRLESparseResourceAllocation::removeInterval return bool, to allow the caller to determine
whether or not the method call succeeded?
* NIT: Please add a test case in PeriodicRLESparseResourceAllocation::testPeriodicCapacity,
PeriodicRLESparseResourceAllocation::testRemoveInterval that does not land on a timeStep.
* Do we need to handle the possibility of negative periodic capacity when PeriodicRLESparseResourceAllocation::removeInterval
is used?


> Extend RLESparseResourceAllocation with period for supporting recurring reservations
in YARN ReservationSystem
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5331
>                 URL: https://issues.apache.org/jira/browse/YARN-5331
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Sangeetha Abdu Jyothi
>              Labels: oct16-medium
>         Attachments: YARN-5331.001.patch, YARN-5331.002.patch, YARN-5331.003.patch, YARN-5331.004.patch,
YARN-5331.005.patch
>
>
> YARN-5326 proposes adding native support for recurring reservations in the YARN ReservationSystem.
This JIRA is a sub-task to add a PeriodicRLESparseResourceAllocation. Please refer to the
design doc in the parent JIRA for details.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message