Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 24 Feb 2017 05:02:44 +0000 (UTC)
From: "Rohith Sharma K S (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13030546.1482740266000.51891.1487912564300@Atlassian.JIRA>
In-Reply-To: <JIRA.13030546.1482740266000@Atlassian.JIRA>
References: <JIRA.13030546.1482740266000@Atlassian.JIRA> <JIRA.13030546.1482740266230@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-6027) Support fromid(offset) filter for
 /flows API
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 24 Feb 2017 05:02:56 -0000


    [ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881960#comment-15881960 ] 

Rohith Sharma K S commented on YARN-6027:
-----------------------------------------

bq. I am a little curious about this refactoring. Is the idea to split the current reader unit tests based on this abstract class?
Yes, it is refactoring of TestTimelineReaderWebServicesHBaseStorage. This class has everything mixed up which can be moved to separate class which can be re used. 
bq. it might be better to place it in the reader package and indicate that in the class name also; e.g. AbstractTimelineReaderHBaseTestBase
Agree

> Support fromid(offset) filter for /flows API
> --------------------------------------------
>
>                 Key: YARN-6027
>                 URL: https://issues.apache.org/jira/browse/YARN-6027
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-6027-YARN-5355.0001.patch, YARN-6027-YARN-5355.0002.patch, YARN-6027-YARN-5355.0003.patch, YARN-6027-YARN-5355.0004.patch
>
>
> In YARN-5585 , fromId is supported for retrieving entities. We need similar filter for flows/flowRun apps and flow run and flow as well. 
> Along with supporting fromId, this JIRA should also discuss following points
> * Should we throw an exception for entities/entity retrieval if duplicates found?
> * TimelieEntity :
> ** Should equals method also check for idPrefix?
> ** Does idPrefix is part of identifiers?


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org