Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 7 Feb 2017 23:17:42 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12901530.1443600779000.22491.1486509462739@Atlassian.JIRA>
In-Reply-To: <JIRA.12901530.1443600779000@Atlassian.JIRA>
References: <JIRA.12901530.1443600779000@Atlassian.JIRA> <JIRA.12901530.1443600779448@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-4212) FairScheduler: Parent queues is not
 allowed to be 'Fair' policy if its children have the "drf" policy
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 07 Feb 2017 23:17:49 -0000


    [ https://issues.apache.org/jira/browse/YARN-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857005#comment-15857005 ] 

ASF GitHub Bot commented on YARN-4212:
--------------------------------------

Github user kambatla commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/181#discussion_r99954759
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSQueue.java ---
    @@ -463,4 +461,33 @@ boolean fitsInMaxShare(Resource additionalResource) {
         }
         return true;
       }
    +
    +  /**
    +   * Recursively check policies for queues in pre-order. Get queue policies
    +   * from the allocation file instead of properties of {@link FSQueue} objects.
    +   * Set the policy for current queue if there is no policy violation for its
    +   * children.
    +   *
    +   * @param queueConf allocation configuration
    +   * @return true if no policy violation and successfully set polices
    +   *         for queues; false otherwise
    +   */
    +  public boolean verifyAndSetPolicyFromConf(AllocationConfiguration queueConf) {
    --- End diff --
    
    It might be worthwhile to point out the intended caller for this method. 


> FairScheduler: Parent queues is not allowed to be 'Fair' policy if its children have the "drf" policy
> -----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4212
>                 URL: https://issues.apache.org/jira/browse/YARN-4212
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Arun Suresh
>            Assignee: Yufei Gu
>              Labels: fairscheduler
>         Attachments: YARN-4212.002.patch, YARN-4212.003.patch, YARN-4212.004.patch, YARN-4212.005.patch, YARN-4212.006.patch, YARN-4212.007.patch, YARN-4212.008.patch, YARN-4212.1.patch
>
>
> The Fair Scheduler, while performing a {{recomputeShares()}} during an {{update()}} call, uses the parent queues policy to distribute shares to its children.
> If the parent queues policy is 'fair', it only computes weight for memory and sets the vcores fair share of its children to 0.
> Assuming a situation where we have 1 parent queue with policy 'fair' and multiple leaf queues with policy 'drf', Any app submitted to the child queues with vcore requirement > 1 will always be above fairshare, since during the recomputeShare process, the child queues were all assigned 0 for fairshare vcores.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org