From yarn-issues-return-108410-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Wed Feb 22 19:53:51 2017 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A4F52190B2 for ; Wed, 22 Feb 2017 19:53:51 +0000 (UTC) Received: (qmail 29609 invoked by uid 500); 22 Feb 2017 19:53:51 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 29578 invoked by uid 500); 22 Feb 2017 19:53:51 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 29566 invoked by uid 99); 22 Feb 2017 19:53:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Feb 2017 19:53:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E79F518E16A for ; Wed, 22 Feb 2017 19:53:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.198 X-Spam-Level: X-Spam-Status: No, score=-1.198 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id p2NF6sc_LnNS for ; Wed, 22 Feb 2017 19:53:50 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7E3A35FACC for ; Wed, 22 Feb 2017 19:53:49 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 017C0E0A6C for ; Wed, 22 Feb 2017 19:53:45 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5F84D2412B for ; Wed, 22 Feb 2017 19:53:44 +0000 (UTC) Date: Wed, 22 Feb 2017 19:53:44 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-6194) Cluster capacity in SchedulingPolicy is updated only on allocation file reload MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879093#comment-15879093 ] ASF GitHub Bot commented on YARN-6194: -------------------------------------- Github user kambatla commented on a diff in the pull request: https://github.com/apache/hadoop/pull/196#discussion_r102554581 --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSContext.java --- @@ -27,28 +29,37 @@ private boolean preemptionEnabled = false; private float preemptionUtilizationThreshold; private FSStarvedApps starvedApps; + private FairScheduler scheduler; + + FSContext(FairScheduler scheduler) { + this.scheduler = scheduler; + } - public boolean isPreemptionEnabled() { + boolean isPreemptionEnabled() { return preemptionEnabled; } - public void setPreemptionEnabled() { + void setPreemptionEnabled() { this.preemptionEnabled = true; if (starvedApps == null) { starvedApps = new FSStarvedApps(); } } - public FSStarvedApps getStarvedApps() { + FSStarvedApps getStarvedApps() { return starvedApps; } - public float getPreemptionUtilizationThreshold() { + float getPreemptionUtilizationThreshold() { return preemptionUtilizationThreshold; } - public void setPreemptionUtilizationThreshold( + void setPreemptionUtilizationThreshold( float preemptionUtilizationThreshold) { this.preemptionUtilizationThreshold = preemptionUtilizationThreshold; } + + public Resource getClusterResource() { + return scheduler.getClusterResource(); --- End diff -- This looks okay for now, but this allows a scheduling policy to modify the overall cluster's resources. Making a copy could be expensive, as this is called on every compare call. > Cluster capacity in SchedulingPolicy is updated only on allocation file reload > ------------------------------------------------------------------------------ > > Key: YARN-6194 > URL: https://issues.apache.org/jira/browse/YARN-6194 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler > Affects Versions: 2.8.0 > Reporter: Karthik Kambatla > Assignee: Yufei Gu > > Some of the {{SchedulingPolicy}} methods need cluster capacity which is set using {{#initialize}} today. However, {{initialize()}} is called only on allocation reload. If nodes are added between reloads, the cluster capacity is not considered until the next reload. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org