hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6245) Add FinalResource object to reduce overhead of Resource class instancing
Date Mon, 27 Feb 2017 22:30:45 GMT

    [ https://issues.apache.org/jira/browse/YARN-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886660#comment-15886660
] 

Wangda Tan commented on YARN-6245:
----------------------------------

Thanks [~kasha],

bq. What do you think of an approach where ImmutableResource extends Resource but throws an
UnsupportedException on modification? 
Sounds good to me.

bq. Resource could have a getImmutableCopy() method that returns a copy.
So does it mean: {{immutable_add(a, b) = new ImmutableResource(add(a.getImmutable(), b.getImmutable()))}}?
If so, this approach might be inefficient since it will generate lots of immutable objects.
And under the context of YARN-3926, I'm not sure what is the most efficient way to handle
ImmutableResource object with extensible types.

> Add FinalResource object to reduce overhead of Resource class instancing
> ------------------------------------------------------------------------
>
>                 Key: YARN-6245
>                 URL: https://issues.apache.org/jira/browse/YARN-6245
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>         Attachments: YARN-6245.preliminary-staled.1.patch
>
>
> There're lots of Resource object creation in YARN Scheduler, since Resource object is
backed by protobuf, creation of such objects is expensive and becomes bottleneck.
> To address the problem, we can introduce a FinalResource (Is it better to call it ImmutableResource?)
object, which is not backed by PBImpl. We can use this object in frequent invoke paths in
the scheduler.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message