hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6232) Update resource usage and preempted resource calculations to take into account all resource types
Date Tue, 28 Feb 2017 10:00:53 GMT

    [ https://issues.apache.org/jira/browse/YARN-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887705#comment-15887705
] 

Sunil G commented on YARN-6232:
-------------------------------

Generally changes looks fine for me.

Few minor comments:
# 1. In {{getResourceSecondsString}}, usage of {{getOrDefault}} could be avoided as we may
need to back port to branch-2. Similarly in {{ApplicationAttemptStateData}} as well
# {{RMAppManager#createAppSummary}} has a typo. {{.add("resourceSeonds", StringHelper}}
# In {{RMAppAttemptMetrics}}, instead of using {{private Map<String, AtomicLong> resourceUsageMap
= new HashMap<>();}}, could we use ConcurrentHashMap itself.?
# New UI changes will be handled in separate jira as changes are from client end.

> Update resource usage and preempted resource calculations to take into account all resource
types
> -------------------------------------------------------------------------------------------------
>
>                 Key: YARN-6232
>                 URL: https://issues.apache.org/jira/browse/YARN-6232
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: YARN-6232-YARN-3926.001.patch, YARN-6232-YARN-3926.002.patch
>
>
> The chargeback calculations that take place on the RM should be updated to take all resource
types into account.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message