hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-6211) Synchronization improvement in move and priority
Date Wed, 22 Feb 2017 06:01:44 GMT

    [ https://issues.apache.org/jira/browse/YARN-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877534#comment-15877534
] 

Sunil G edited comment on YARN-6211 at 2/22/17 6:01 AM:
--------------------------------------------------------

Few more minor nit:
# There are unused imports in {{RMAppManager}}, please remove that also.
# Adding to [~rohithsharma] comments, in moveApplicationAcrossQueue and updateApplicationPriority,
appId from request itself could be passed. But you can have null check for app, to ensure
that app is not removed when call reaches at either of these two methods.
# To avoid taking appId reference from RMApp, you may not need to do in RMAppManager. Instead
you can pass rmApp.getApplicationId() from ClientRMService api itself.


was (Author: sunilg):
One more minor nit:
# There are unused imports in {{RMAppManager}}, please remove that also.
# Adding to [~rohithsharma] comments, in moveApplicationAcrossQueue and updateApplicationPriority,
appId from request itself could be passed. But you can have null check for app, to ensure
that app is not removed when call reaches at either of these two methods.

> Synchronization improvement in move and priority
> ------------------------------------------------
>
>                 Key: YARN-6211
>                 URL: https://issues.apache.org/jira/browse/YARN-6211
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: YARN-6211.001.patch
>
>
> Application appid is wrongly taken for synchronization



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message