hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlo Curino (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-6190) Bug fixes in federation polices
Date Tue, 14 Feb 2017 22:04:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866793#comment-15866793
] 

Carlo Curino edited comment on YARN-6190 at 2/14/17 10:03 PM:
--------------------------------------------------------------

Hi [~botong],

Thanks for the patch, it looks good in general. I believe that:
 * The synchronized are probably redundant (the invoker is single threaded, and we guarded
headroom, but making it ConcurrentHashMap... the only thing to double check is whether/if
the scan of headroom is compatible with a put).
 * Don't fix java 8 / java 7 issues like ArralyList<> in this, worth doing only if/when
we backport with java7 only branches
 * I think you are correct on using ResourceRequest instead of instance when invoking static
methods (cleaner)
 * I think the null check for weights is also a correct fix. Please add a test to verify that
we cover this.


was (Author: curino):
Hi [~botong],

Thanks for the patch, it looks good in general. I believe that:
1) The synchronized are probably redundant (the invoker is single threaded, and we guarded
headroom, but making it ConcurrentHashMap... the only thing to double check is whether/if
the scan of headroom is compatible with a put).
2) Don't fix java 8 / java 7 issues like ArralyList<> in this, worth doing only if/when
we backport with java7 only branches
3) I think you are correct on using ResourceRequest instead of instance when invoking static
methods (cleaner)
4) I think the null check for weights is also a correct fix. Please add a test to verify that
we cover this.

> Bug fixes in federation polices
> -------------------------------
>
>                 Key: YARN-6190
>                 URL: https://issues.apache.org/jira/browse/YARN-6190
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: federation
>            Reporter: Botong Huang
>            Assignee: Botong Huang
>            Priority: Minor
>         Attachments: YARN-6190-YARN-2915.v1.patch
>
>
> A bug fix in LocalityMulticastAMRMProxyPolicy on policy array condition check, along
with misc cleanups. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message