hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Botong Huang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6190) Bug in LocalityMulticastAMRMProxyPolicy argument validation
Date Thu, 23 Feb 2017 21:15:44 GMT

    [ https://issues.apache.org/jira/browse/YARN-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881278#comment-15881278
] 

Botong Huang commented on YARN-6190:
------------------------------------

Thanks [~curino] for the feed back. For 1), the Federation Interceptor code doesn't have synchronization
on allocate calls. It can be processing allocate calls concurrently. So I believe we do need
to cover concurrency here. 

I just uploaded the v2 patch. Instead of using synchronization on the entire object, we can
create a new {{AllocationBookkeeper}} object per splitResourceRequests call. 

I also modified the way we compute the weights for any request with a request id. Specifically,
rather than divide the local weight by the total weight for all request ids, we should divide
by the total weight associated with the specific request id. 

Please take a look. Thanks! 

> Bug in LocalityMulticastAMRMProxyPolicy argument validation
> -----------------------------------------------------------
>
>                 Key: YARN-6190
>                 URL: https://issues.apache.org/jira/browse/YARN-6190
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: federation
>            Reporter: Botong Huang
>            Assignee: Botong Huang
>            Priority: Minor
>         Attachments: YARN-6190-YARN-2915.v1.patch, YARN-6190-YARN-2915.v2.patch
>
>
> A bug fix in LocalityMulticastAMRMProxyPolicy on policy array condition check, along
with misc cleanups. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message