hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2
Date Fri, 10 Feb 2017 23:05:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861975#comment-15861975

Varun Saxena commented on YARN-6170:

Changes look fine to me. Will commit it by tomorrow.

> TimelineReaderServer should wait to join with HttpServer2
> ---------------------------------------------------------
>                 Key: YARN-6170
>                 URL: https://issues.apache.org/jira/browse/YARN-6170
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelinereader
>    Affects Versions: 3.0.0-alpha2, YARN-5355
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>            Priority: Minor
>         Attachments: YARN-6170.01.patch
> While I was backporting YARN-5355-branch-2 to a 2.6.0-based code branch, I noticed that
the timeline reader daemon would promptly shut down upon start. It turns out that in the 2.6.0
code line at least there are only daemon threads left once the main method returns. That causes
the JVM to shut down.
> The right pattern to start an embedded jetty web server is to call {{Server.start()}}
followed by {{Server.join()}}. That way, the server stays up reliably no matter what other
threads get created.
> It works on YARN-5355 only because there *happens* to be one other non-daemon thread.
We should add the {{join()}} call to be always correct.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message